From 992ee6a20302585ac45149ac54ceda8f2c684eb0 Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Mon, 11 Apr 2011 01:51:49 +0200 Subject: [PATCH] cssprovider: Emit a g_warning() when a css file is erroneous ... and no other error handler is active. See the source code comment for the reasoning. --- gtk/gtkcssprovider.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/gtk/gtkcssprovider.c b/gtk/gtkcssprovider.c index 4a3b833d52..9e6d3c8572 100644 --- a/gtk/gtkcssprovider.c +++ b/gtk/gtkcssprovider.c @@ -876,6 +876,20 @@ gtk_css_provider_parsing_error (GtkCssProvider *provider, priv->error = g_error_copy (error); g_prefix_error (&priv->error, "%s:%u:%u: ", path ? path : "", line, position); } + + /* Only emit a warning when we have no error handlers. This is our + * default handlers. And in this case erroneous CSS files are a bug + * and should be fixed. + * Note that these warnings can also be triggered by a broken theme + * that people installed from some weird location on the internets. + */ + if (!g_signal_has_handler_pending (provider, + css_provider_signals[PARSING_ERROR], + 0, + TRUE)) + { + g_warning ("Theme parsing error: %s:%u:%u: %s", path ? path : "", line, position, error->message); + } } static void -- 2.30.2